Restrict xgui ConCommand

[Darkblizzard]

Hello,
I'm trying to restrict it so the concommand "xgui" or "ulx menu" doesn't open unless in a certain usergroup. I would use the Garry's Mod functions, but looking through the code each one begins with "xgui.". Is there a specific way to do this without having to damage the code?
Thanks!

[Megiddo]

You should be able to restrict access to the "xgui" command inside of XGUI, just like you do with the other ULX commands.

[Stickly Man!]

Actually, the xgui commands are defined on the client:
https://github.com/TeamUlysses/ulx/blob/master/lua/ulx/modules/cl/xgui_client.lua#L562-L568

My reasoning at the time was that even regular users have access to at least one or two ulx commands.

You can probably write some lua code that loads after xgui initializes to override the xgui.show function. Something like this should do (untested code):

Code: Lua

1. -- After xgui_client.lua has loaded (ulx module)
2. local oldShow = xgui.show
3. function xgui.show(tabname)
4.     if yourCustomCheckToSeeIfTheyCanOpenXgui then
5.         oldShow(tabname)
6.     end
7. end
8.  

[Darkblizzard]

Sorry for the late response, but if I wanted to use "ply:IsSuperAdmin()", where does it recognize the "ply"?

[MrPresident]

That would be the player object as a variable passed into the function you are working within.

So, for example in this code:

Code: [Select]


function TestFunction( ply )
    print ( ply:IsSuperAdmin() )
end


The ply INSIDE the function... the one that is attached to :IsSuperAdmin() is accepted as the arguement passed into the function TestFunction() so outside the function, when you call the function TestFunction() you would need to make sure to pass it a player object.

example:

Code: [Select]


TestFunction( ULib.getUser("darkblizzard") )


Does that make sense?

lua is loosely typed.. meaning that variables don't require being defined with a type.. as long as what you set is the data type that is expected when you try and use it later, it will function.

[MrPresident]

Now... let's say you're working within a ULX command structure.. which you probably are (maybe?)

Take a look at the code for the !slap command

Code: [Select]

------------------------------ Slap ------------------------------
function ulx.slap( calling_ply, target_plys, dmg )
local affected_plys = {}

for i=1, #target_plys do
local v = target_plys[ i ]
if v:IsFrozen() then
ULib.tsayError( calling_ply, v:Nick() .. " is frozen!", true )
else
ULib.slap( v, dmg )
table.insert( affected_plys, v )
end
end

ulx.fancyLogAdmin( calling_ply, "#A slapped #T with #i damage", affected_plys, dmg )
end

local slap = ulx.command( CATEGORY_NAME, "ulx slap", ulx.slap, "!slap" )
slap:addParam{ type=ULib.cmds.PlayersArg }
slap:addParam{ type=ULib.cmds.NumArg, min=0, default=0, hint="damage", ULib.cmds.optional, ULib.cmds.round }
slap:defaultAccess( ULib.ACCESS_ADMIN )
slap:help( "Slaps target(s) with given damage." )

notice how at the top where the function is defined, there are variable names passed into it. calling_ply, target_plys and dmg

In the code calling_ply is the one who RAN the command.. so if you wanted to check if that player was a superadmin.. you would use calling_ply:IsSuperAdmin() not ply:IsSuperAdmin().. that's because the player object passed into the function is calling_ply

the target_plys variable is a table of player objects.. further in the code you'll notice how we're iterating through that table with a for loop. In that case.. the player being checked in the loop is 'v'.



I know this is a bit confusing if you're not used to programming, but I think it is pretty straight forward.

let me know if you have any more questions.

[Darkblizzard]

Oh no, I understand how that works, and actually made some code myself using that. What I don't understand is where to get "ply" when working in the xgui client? The xgui.open function does not have "ply", and it appears like all the functions are rather custom which makes me nervous about breaking any of the code within.

[MrPresident]

XGUI is clientside.. so ply would just be LocalPlayer()

[Darkblizzard]

Thanks for the help!