Command redirection

[Zealot]

Hello.  I am trying to fix this script so that when the player uses the command "noclip" it redirects it to "ulx noclip".  I thought I had it at first, but it doesn't work.  Can anyone tell me what I may be doing wrong?

Code: [Select]

hook.Add("ULibCommandCalled", "PreventTheNoclip", function(ply, cmd, args)
if cmd == "noclip" then
return ply:Team() == TEAM_MODERATOR or ply:IsSuperAdmin()
ply:ConCommand( "ulx noclip" )
end
end)
Any help would be appreciated.

[BlueNova]

Without doing something other than a quick read, you have it returning before you have the player run noclip. So the hook will stop. Maybe just replace the return statement with an if/else statement?

[JamminR]

Will standard server/client console command "noclip" trigger ULibcommandcalled?
noclip is a standard server function, not even part of ULib.
I imagine, it's possible, since we hook into ALL hooks with a priority system, that we might see it.
I'm not sure that's intentional though, and wouldn't expect ULibcommandcalled to be called.

(Oh, and BlueNova, nice to see you here)

EDIT - In addition to BlueNova's suggestions, you may have better luck with the GM:PlayerNoClip hook.

[Zealot]

Hello.  I am not currently at my computer, but do you all think this would work?

Code: [Select]

hook.Add("PlayerNoClip", "PreventTheNoclip", function(ply, cmd, args)
if cmd == "noclip" then
If table.HasValue({TEAM_MODERATOR} ply:Team()) or ply:IsSuperAdmin()
ply:ConCommand( "ulx noclip" )
                end
end
end)
Let me know what you think.

[BlueNova]

Hello.  I am not currently at my computer, but do you all think this would work?

Code: [Select]

hook.Add("PlayerNoClip", "PreventTheNoclip", function(ply, cmd, args)
if cmd == "noclip" then
If table.HasValue({TEAM_MODERATOR} ply:Team()) or ply:IsSuperAdmin()
ply:ConCommand( "ulx noclip" )
                end
end
end)
Let me know what you think.

Well unless TEAM_MODERATOR is a table full of teams that would classify them as staff then probably not. You'd be better off by something closer to this...

Code: Lua

1. if ply:Team() == TEAM_MODERATOR or ply:IsSuperAdmin() then
2.      -- blah blah blah
3. end

[Zealot]

Well unless TEAM_MODERATOR is a table full of teams that would classify them as staff then probably not. You'd be better off by something closer to this...

Code: Lua

1. if ply:Team() == TEAM_MODERATOR or ply:IsSuperAdmin() then
2.      -- blah blah blah
3. end

You misinterpret my table check.
But regardless, I think I have a final version for the script.

Code: [Select]

hook.Add("PlayerNoClip", "PreventTheNoclip", function(ply, isallowed)
if !isallowed then
if table.HasValue({TEAM_MODERATOR}, ply:Team()) or ply:IsSuperAdmin then
                ply:ConCommand("ulx noclip")
end
end
if isallowed then return end
end)
I have not tested this at a computer yet.  I am on a work laptop.
First, there was the problem with the hook.  PlayerNoClip definitely looked like the hook I was looking for, so thank you for pointing me towards that.  Second, the way I was addressing the function would not work with the PlayerNoClip hook.  That has two identifiers:
player, and IsNoclipAllowed.  Therefore, I changed it so that if noclip is NOT allowed then we initiate the script.  However, if it is allowed, we return the script.
Again, I have not tested this out.  I will test it when I get home.