Bug 208

[JamminR]

Re : http://ulyssesmod.net/bugs/view.php?id=208

For the first time in probably months, I've looked at code not related to work (and enjoyed it, a little, gimme time. Work's killing me)
I see that ULib.addBan does no error checking for any syntax before it goes into a table and gets parsed into keyvalues.

Would the following solution fix the bug mentioned in 208?

Code: [Select]

function ULib.addBan( steamid, time, reason, name, admin )
local t = {}
t.time = os.time()
if time > 0 then
t.unban = ( ( time * 60 ) + t.time )
else
t.unban = 0
end
if reason then
t.reason = ULib.makePatternSafe( reason )
end
if name then
t.name = ULib.makePatternSafe( name )
end
if admin then
t.admin = "Console(Console)"
if admin:IsValid() then
t.admin = string.format( "%s(%s)", ULib.makePatternSafe( admin:Name() ), admin:SteamID() )
end
end
ULib.bans[ steamid ] = t
file.Write( ULib.BANS_FILE, ULib.makeKeyValues( ULib.bans ) )
end

OR, would the better method be to modify makeKeyValues to clean any strings?


Megiddo, we should probably get jay a mantis account until we decide on Flyspray or not.
He could at least assign himself anything he wants to dig into.

[JamminR]

I see my idea would fail (it doesn't do anything for slashes)
Still, I wonder if it would be good for cleanup before going to makekeyvalues, or making keyvalues do the cleanup of the input.

(Wait, didn't I just say a few days ago I wouldn't be interested in unit testing)

[Megiddo]

Did anyone ever actually provide us with a file like this? I'd need to see it to fix it.

[JamminR]

Did anyone ever actually provide us with a file like this? I'd need to see it to fix it.

We've asked, but the forum won't allow them to post a 65mb file in text, and we didn't ask them to try to zip.
Perhaps we should ask someone to post a compressed zip on the bug tracker.
Zipped, shouldn't be that large.