Group names in echo and log files

[JamminR]

Megiddo, all
Any opposition to me adding in group names to the log.lua file for #A and #T when actions are performed on players?
We'd discussed it in a previous thread here, and even commited changes, but either it didn't commit like I thought, or got overwritten during the mass re-write occurring during that time.

[Megiddo]

It was removed because names are colored by group anyways. It was removed from the logs to stay consistent with what was shown on the screen.

Is there any reason why the group would be useful in the logs?

[JamminR]

Because from ded console, and in a text file... no colors appear?

Theoretically, but would apply to ULX text logs too;
If I'm reviewing security logs and see that a standard user somehow had superuser group access....it may not tell me how, but it at least shows me at which point in a time line the person didn't then did have it...OR, if they had the same level access, but somehow performed a superuser access command.

[Megiddo]

Well, the complaint we had with the old way of showing (Admin) was just the fact that admin (as in group) was confusing (we meant admin privileges). I can see where reviewing logs might come in handy if there were some sort of break in chain of command, though.

[JamminR]

So in other words, "No JamminR, I see your point, but don't feel the idea as a whole would be useful for everyone else."


I'm trying to find easy stuff to do within ULX.
Perhaps I'll rewrite MrPresident's "ulx explode" release to be compatible with current command structure.
I'm still not clear myself (even though I was a part of the original discussions) on how it all works now that I actually see the inputs.
Converting already existing code would help me learn it.

[Megiddo]

So in other words, "No JamminR, I see your point, but don't feel the idea as a whole would be useful for everyone else."


I'm trying to find easy stuff to do within ULX.
Perhaps I'll rewrite MrPresident's "ulx explode" release to be compatible with current command structure.
I'm still not clear myself (even though I was a part of the original discussions) on how it all works now that I actually see the inputs.
Converting already existing code would help me learn it.

I'm not saying it's a bad idea, I think we should ask admins to see what they think.

[JamminR]

Converted (at least working in singleplayer) MrPresident's "ulx explode" module.
One issue I see though...when I use the chat command on myself

Code: [Select]

!explode ^ 50000 9999

I see this come up in the chat text.

Code: [Select]

*DEAD* [ULX]JamminR: !explode ^ 50000 9999

Officially, I'm not dead until after the command is run.
Whatever checks for, and prints out the 'dead' runs after the death though.
Any easy way to prevent that in passed parameters?
Here's what use for its options.

Code: Lua

1. local explode = ulx.command( CATEGORY_NAME, "ulx explode", ulx.explode, "!explode" )
2. explode:addParam{ type=ULib.cmds.PlayersArg }
3. explode:addParam{ type=ULib.cmds.NumArg, min=0, max=50000, default=250, hint="damage", ULib.cmds.optional, ULib.cmds.round }
4. explode:addParam{ type=ULib.cmds.NumArg, min=0, max=10000, default=150, hint="radius", ULib.cmds.optional, ULib.cmds.round }
5. explode:defaultAccess( ULib.ACCESS_ADMIN )
6. explode:help( "Explodes target(s) with given <damage> and <radius> blast area [Danger - could hurt other players!]" )
7. explode:logString( "#1s exploded #2s with #3i damage in a #4i radius blast area" )
8. ulx.addToMenu( ulx.ID_MCLIENT, "Explode", "ulx explode" )
9.  

[Megiddo]

Odd, it doesn't show up as dead if you use !slay ^, does it?

[JamminR]

Actually, yes. Just tried in a ded server I started on local machine.

Code: [Select]

*DEAD* [ULX]JamminR: !slay ^
You slayed yourself

Also... I now see why a user in the forums was asking for revision # before colors.
Though a nice touch...I have trouble seeing some of them.
Though my vision is problematic when it comes to contrasts (not sure the rest of the team knows that, ask me later in IM if you want details), even with good vision I could imagine having trouble seeing them unless a player had the text box up (which has a grey background by default). The dark blue of 'you' and 'yourself' seemed difficult to see.

Are colors going to be a configuration item, enable/disable, default colors for various things?