Respected Rank

[TropicalTitties]

How would i make it so that people would have to have a certain rank, such as respected (or above), in order to become a class, such as swat? However, the respected rank would not have admin privileges, just the ability to become swat and other respected rank.

Would I use a function, such as:

Code: [Select]

function GM:PlayerJoinTeam( ply, class, teamid )
if ply:IsUserGroup("User") and teamid == TEAM_SWAT then
return false
else
return true
end
end

Or something else?
I honestly cant figure out what else to try.


^{EDIT-JamminR Added code block}

[JamminR]

Way you have it is the basic idea, but, you need to use lower case when comparing groups. "user" not "User"
A better way to do it, since some groups inherit lower ones, is probably test for the "respected" specifically.
Also, in 99% of Gmod lua, when you wish a hook function to continue, don't return "true", just return.
There are exceptions, but, returning anything will often break the hooks of other mods/scripts using the same hook, even if it is only 'true'
(Yes, I know, the Gmod wiki is full of 'return true'...many hooks break others that way.

Code: [Select]

function GM:PlayerJoinTeam( ply, class, teamid )
if not ply:IsUserGroup("respected") and teamid == TEAM_SWAT then
return false
else
return
end
endIn english, the above statement reads
if player is not in group respected and they want to join Swat team, do nothing, else if they are in group respected and want to join swat, go ahead.

[MrPresident]

In this situation he would want to use return true.

If you are calling a function and expecting a boolean value then returning true/false in that function is appropriate. It's generally okay to return true unless you are using it in a hook (like JamminR said).


for example:::

Code: Lua

1.  
2. function TestFunction()
3.     if IsATree( entity ) then
4.         Print("This is a Tree")
5.     else
6.         Print("This is NOT a Tree")
7.     end
8. end
9.  
10. function IsATree( entity )
11.     if entity:GetModel() == "models/props/tree.mdl" then
12.         return true
13.     else
14.         return false
15.     end
16. end
17.  
18.  

It's kind of rough.. some of it's pseudo(ish) code...

[JamminR]

In this situation he would want to use return true.

But, with GM:<function> being a gamemode hook, wouldn't he NOT want to return anything if he wanted all other scripts calling it to continue, including whatever game uses a "Swat" team?

I really am ignorant and out of practice, and to be honest, never have fully understood where to allow it when it comes to Gmod.
I understand YOUR (mrP) code perfectly, and know a boolean is expected.
But I thought that Gmod expects no boolean values unless false though, and breaks stuff if one is received even when true.

[TropicalTitties]

Thanks guys, and Jammin i understand your code perfectly and it should work, although it doesnt. Ive tried using both return true and return.

however neither of these seem to work and normal users can still become the SWAT . I used the exact code that jammin used, with and without the true after return.

Code: [Select]

function GM:PlayerJoinTeam( ply, class, teamid )
if not ply:IsUserGroup("respected") and teamid == TEAM_SWAT then
return false
else
return true
end
end


[Megiddo]

Where is this code being added?

[TropicalTitties]

gamemodes/DarkRP/gamemode/sv_gamemode_functions.lua

[Megiddo]

gamemodes/DarkRP/gamemode/sv_gamemode_functions.lua

Are you sure that this gamemode doesn't already have a PlayerJoinTeam function?

[Aaron113]

Gamemode.PlayerJoinTeam
According to this you have the arguments in the function wrong.

[TropicalTitties]

So it would be

Code: [Select]

function GM:PlayerJoinTeam( ply, teamid )
if not ply:IsUserGroup("respected") and teamid == TEAM_SWAT then
return false
else
return true
end
end