ULX Slay command with a Reason.

[CheesyViking]

Hey, I'm Ricky and I'm just trying to figure out how to add a reason to the slay command.

Code: [Select]

function ulx.slay( calling_ply, target_plys )
local affected_plys = {}

for i=1, #target_plys do
local v = target_plys[ i ]

if ulx.getExclusive( v, calling_ply ) then
ULib.tsayError( calling_ply, ulx.getExclusive( v, calling_ply ), true )
elseif not v:Alive() then
ULib.tsayError( calling_ply, v:Nick() .. " is already dead!", true )
elseif v:IsFrozen() then
ULib.tsayError( calling_ply, v:Nick() .. " is frozen!", true )
else
v:Kill()
table.insert( affected_plys, v )
end
end

ulx.fancyLogAdmin( calling_ply, "#A slayed #T", affected_plys )
end
local slay = ulx.command( CATEGORY_NAME, "ulx slay", ulx.slay, "!slay" )
slay:addParam{ type=ULib.cmds.PlayerArg }
slay:addParam{ type=ULib.cmds.StringArg, hint="reason", ULib.cmds.optional, ULib.cmds.takeRestOfLine, completes=ulx.common_kick_reasons }
slay:defaultAccess( ULib.ACCESS_ADMIN )
slay:help( "Slays Target." )
That is what i've got so far, but it prints this error into console.
addons/ulx/lua/ulx/modules/sh/fun.lua:75: attempt to get length of local 'target_plys' (a userdata value)
I did copy over the thing from the kick command and try edit it. But it prints that into console and dosen't slay the player.

Any help would be highly appreciated.

[bender180]

adding the string pram is a good start but you also need to include a few other things

You need to include the string with the function so

Code: Lua

1. function ulx.slay( calling_ply, target_plys )

needs to be

Code: Lua

1. function ulx.slay( calling_ply, target_plys, reason )

and you need to tell facylog to echo it so

Code: Lua

1. ulx.fancyLogAdmin( calling_ply, "#A slayed #T", affected_plys )

should be

Code: Lua

1. ulx.fancyLogAdmin( calling_ply, "#A slayed #T for #S", affected_plys, reason )

Hope this helps if your still a little confussed (or i got it wrong) someone who knows more will correct me or provide more details im sure.

[Megiddo]

Bender's modification is correct if you have only modified the parameters by adding the reason string, but I see you also changed "PlayersArg" to "PlayerArg"; was this intentional? If so, you'll need to restructure the function to accept the single player instead of a player table.

[JamminR]

Example code of what Megiddo said (since you're learning our command structure) = You converted the slay command from a multiple user command ( nick,nick2,nick3 or *) to a single target (nick or ^) command.
In the original slay command

Code: [Select]

slay:addParam{ type=ULib.cmds.PlayersArg }
You converted to

Code: [Select]

slay:addParam{ type=ULib.cmds.PlayerArg }

ULX uses ULib to strictly watch this, and would return an error if you tried to target multiple users without having the proper command set up.

[CheesyViking]

Alright I've made it so it actually slays the user thanks to everyone. But there is one more problem, it dosen't print anything into the chat. I want it to print like Aqua slayed Blah for RDM or something like that. This is the code so far.

Code: [Select]

function ulx.slay( calling_ply, target_plys, reason )
local affected_plys = {}

for i=1, #target_plys do
local v = target_plys[ i ]

if ulx.getExclusive( v, calling_ply ) then
ULib.tsayError( calling_ply, ulx.getExclusive( v, calling_ply ), true )
elseif not v:Alive() then
ULib.tsayError( calling_ply, v:Nick() .. " is already dead!", true )
elseif v:IsFrozen() then
ULib.tsayError( calling_ply, v:Nick() .. " is frozen!", true )
else
v:Kill()
table.insert( affected_plys, v )
end
end

ulx.fancyLogAdmin( calling_ply, "#A slayed #T for #S", affected_plys, reason )
end
local slay = ulx.command( CATEGORY_NAME, "ulx slay", ulx.slay, "!slay" )
slay:addParam{ type=ULib.cmds.PlayersArg }
slay:addParam{ type=ULib.cmds.StringArg, hint="reason", ULib.cmds.optional, ULib.cmds.takeRestOfLine, completes=ulx.common_kick_reasons }
slay:defaultAccess( ULib.ACCESS_ADMIN )
slay:help( "Slays Target." )

[iSnipeu]

Change "#S" to "#s", I'm pretty sure it's case sensitive.

[Megiddo]

Change "#S" to "#s", I'm pretty sure it's case sensitive.

Good catch iSnipeu, I didn't notice that at first glance.

[iSnipeu]

Is there any reason why slay doesn't have a reason arg in the first place?

[Megiddo]

Is there any reason why slay doesn't have a reason arg in the first place?

Unlike kicking and banning, I don't see a compelling argument for including a reason in it.

[JamminR]

Indeed, kick/ban, person't off the server. Can't see chat anymore.
All the other punishments, person remains on server and the admin doing it can explain why.

[Valgoid]

Just use ULX VoteSlay that I made. You can add a reason.
/index.php/topic,7320.0.html#msg36977