ULX Kick Self Crash

[Hollistupid]

Whenever you kick yourself the server crashes 

Code: [Select]

VeryWetNoodle kicked Themself
Dropped VeryWetNoodle from server ([ULX] Kicked from server)

[ERROR] lua/includes/extensions/player.lua:141: Tried to use a NULL entity!
1. UniqueID - [C]:-1
2. GetPData - lua/includes/extensions/player.lua:141
3. fn - addons/customcommands/lua/ulx/modules/sh/cc_voting.lua:323
4. unknown - addons/ulib/lua/ulib/shared/hook.lua:183

[Hollistupid]

Oh my bad. Remove the "%", so it just says "!^". That should work.
Sorry for the mistake.

Restricting the kick command to not be able to kick self is a temp-fix for my problem and could be a permanent solution. But I still think this could be addressed.

[Decicus]

I'm just letting you know that this has already been reported, so a fix will hopefully be here quite soon.

[Stickly Man!]

As well as crashing issues here: /index.php/topic,7419.0.html

My theory is that chat commands are causing the issue- does the crash occur when called from console as well?
Also, do you use any sort of SQL-based banning system? It is likely a .dll module is causing the crash, but, I haven't been able to investigate yet.

[Avoid]

Hello Stickly Man,
kicking yourself from the game console works fine, however, once you use the !kick/!ban chat command on yourself the server crashes.

So it definatley has something to do with the chatcommands.
~Avoid

[Stickly Man!]

I'm really thinking there's a third party addon causing this issue.. at least, I can't say for sure until I've tested myself. I'll see what I can find out later tonight! (Anyone else is welcome to try it on their own server with ULX only, if possible, to see if it still occurs).

[bender180]

I setup a new server with just ulib/ulx and i can confirm that when kicking yourself via chat command it does crash srcds, kicking yourself via xgui and console don't crash the server however.

[Decicus]

I can also confirm on my own server that banning/kicking yourself through chat crashes the server, and I'm not running any other modules (other than lua addons, which haven't caused the issue before).

UPDATE: Also happens on my local SRCDS server with only ULib/ULX on.

[Stickly Man!]

Oh yeah, it exploded severely. 

But it's fixed now! https://github.com/Nayruden/Ulysses/commit/cd02f4f44514d7f61e1d2b031689150fcc9cf588

I'm willing to bet this is an underlying issue in Garry's Mod itself, so I'm going to put together a simple script to see if I can replicate it...

[Stickly Man!]

Wow, yup- it's an issue with Gmod itself. Run this code on your server, and anyone who says "hi" will crash the server:

Code: Lua

1. local function playerSay( ply, text, private )
2.         if text == "hi" then ply:Kick("") end
3. end
4. hook.Add( "PlayerSay", "test_say", playerSay, 20 )

[Avoid]

Thanks for the quick fixes Stickly! 

[Hollistupid]

Does not seem to be fixed:

Code: [Select]

Dropped Hollistupid from server ([ULX] Kicked from server)

[ERROR] lua/includes/extensions/player.lua:141: Tried to use a NULL entity!
1. UniqueID - [C]:-1
2. GetPData - lua/includes/extensions/player.lua:141
3. fn - addons/customcommands/lua/ulx/modules/sh/cc_voting.lua:323
4. unknown - addons/ulib/lua/ulib/shared/hook.lua:183

[Stickly Man!]

Does it still crash the server? Or just display that lua error?

The cc_voting.lua (custom commands) file also has a hook into PlayerSay. Try temporarily removing that and see if your problem is fixed.

[Zmaster]

I just tested it with the new ULX you linked, and it still crashes the server

[Stickly Man!]

I'm willing to bet it's a third-party addon issue- If you could temporarily remove any addons that might do something with the chat hook, that could help me test. If you get a lua error, that'd be helpful too. Otherwise I'd be willing to hop on any one of your servers when I have a moment to take a look myself.