Help please.

[Unknown Gamer]

Hey,
I need some help with my code. Its suppsed to be when someone types !yes into chat. it returns "Get denied. No." in console. Any help with my code would be appreacitated

Code: [Select]

function ulx.response( PrintMessage )
Player:PrintMessage( HUD_PRINTCONSOLE, "Get denied. No." )
end
end

local response = ulx.response( CATEGORY_NAME, "ulx response", ulx.response, "!yes" )
response:addParam{ type=ULib.cmds.PlayersArg }
response:defaultAccess ( ULib.ACESS.ADMIN )
response:help ( "A test script for creepy" )
This is my first code from scratch. So I may not get things a be a newb.

[JamminR]

If it's not obvious looking over our actual code files, see "NEW STUFF HERE" section of post from some years ago.
How-To/Comparison - ULX SVN vs old ULX release command structure
(Though, technically "new" when that post was written, we've been using the "new" style almost 5 years now)
Oh, and there's a heavily commented file attachment to that post of a previous converted "rocket" command MrPresident wrote.
Comments should be reasonably self explanatory.

Other good posts are the stickies at the top of our developer forum, where I moved your question to.
Want to patch or work on a Ulysses project? Use our codestyle.
ULib Documentation
Resources to get started with Lua

[Unknown Gamer]

*BUMP*

[Neku]

JamminR just gave you a bunch of resources to help you, yet you bump the thread.
For what?

[JamminR]

He posted code change. But, yeah, rather than 'bump', he should have posted a question or statement.
He's not paying attention/learning to read what Gmod errors are telling him.
Gmod would give him 3 errors off the bat.
One about table not expected, one about null variable, one about end of line/function.
1) He's using ULX 'playerSArg...which passes a table of players (even if table only has one player), not a single player .
2) He's not defining the variable for what Player is tied to in the print message.
3) He's also got two "end"s in the function that would only need one at this point.

[Unknown Gamer]

Still kinda don't get it. Could someone replicate what my code should look like so I can see what it should look like?

[Neku]

Sounds like you want someone to make it for you.

[bender180]

I'm bored so I might try and through a rough script together for you, no promise though.

[Zmaster]

When someone types "!yes" into chat, "Get denied. No." is put into their console
I removed the player argument, so you can't do "!yes Garry", for example (assuming someone named Garry is in your server)

Code: Lua

1. function ulx.response( calling_ply )
2.         calling_ply:PrintMessage( HUD_PRINTCONSOLE, "Get denied. No." )
3. end
4.  
5. local response = ulx.command( CATEGORY_NAME, "ulx response", ulx.response, "!yes", true )
6. response:defaultAccess( ULib.ACCESS_ALL )
7. response:help( "A test script for creepy" )

[Unknown Gamer]

When someone types "!yes" into chat, "Get denied. No." is put into their console
I removed the player argument, so you can't do "!yes Garry", for example (assuming someone named Garry is in your server)

Code: Lua

1. function ulx.response( calling_ply )
2.         calling_ply:PrintMessage( HUD_PRINTCONSOLE, "Get denied. No." )
3. end
4.  
5. local response = ulx.command( CATEGORY_NAME, "ulx response", ulx.response, "!yes", true )
6. response:defaultAccess( ULib.ACCESS_ALL )
7. response:help( "A test script for creepy" )

Thank You! I kind of get it. Learned a little from this. Thanks Guys

[JamminR]

Study up on variables, both defined in function, and passed to function.
ULX will always pass calling_ply (this isn't true of lua itself in general)
Here's example of YOUR code, commented to show exactly what should be fixed (somewhat apparent in zmaster, but perhaps not clear to a new coder)

Code: [Select]

function ulx.response( PrintMessage ) -- THE part inside (), is passed TO the function from WHATEVER your calling the function.
-- in the case of ulx, var1, var2.... , var1 is ALWAYS 99% going to be the calling player, hence, we often name it calling_ply, so change "PrintMessage" to calling_ply
Player:PrintMessage( HUD_PRINTCONSOLE, "Get denied. No." ) -- "Player:" is not defined. Null. You could do, before this line, Player == calling_ply, or better yet, just use calling_ply:PrintMessage( ...)
end -- one too many ends....remove it. You didn't use any other if/then/for logic statements that need an end
end -- ends the function.

local response = ulx.response( CATEGORY_NAME, "ulx response", ulx.response, "!yes" )
response:addParam{ type=ULib.cmds.PlayersArg } -- Don't need this line. It would pass var2, in this case, a table of players, we often name the var target_ply
response:defaultAccess ( ULib.ACESS.ADMIN ) -- Tell Ulib the default group needed.
response:help ( "A test script for creepy" ) -- Obvious, adds to the help menu.