Automatically move someone to a group if they join the steam group?

[Jaden Zepeda]

Is this possible with Lua? Automatically moving someone to a ULX group if they join my steam group?
Ulx group: member
Steam group: http://steamcommunity.com/groups/sandboxwars
If someone could write me up a quick code that would be great!

[Jaden Zepeda]

I heard about a Steam callback but I still am clueless on if this is possible or not.

[JamminR]

ULX forum search within Dev corner is your friend.
/index.php/topic,7247.0.html

[Jaden Zepeda]

ULX forum search within Dev corner is your friend.
/index.php/topic,7247.0.html

Wow Great! Sadly I'm still pretty new to Lua, so I have no Idea what function to add so they get ulx group member if they join the steam group.

[Jaden Zepeda]

I thought this would work, replacing the prints with commands, didnt work...
Original:

Code: [Select]

function CommunityCheckStatus( communityID, ply )
        if not IsValid(ply) then return end
        local id = util.SteamIDTo64( ply:SteamID() )
        http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. communityID .. "/memberslistxml/?xml=1?lolwat="..os.time(),
                function( body, _, _, _ )
                        if string.find( body, id ) then
                                SetPlayerMember( ply )
                        else
                                print( "FALSE" )
                        end
                end,
                function( error )
                        print( "Something went terribly wrong!" )
                        print( error )
                end
        )
end
 
function CommunityCheckStatusID( communityID, sid )
        local id = util.SteamIDTo64( sid )
        http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. communityID .. "/memberslistxml/?xml=1?lolwat="..os.time(),
                function( body, _, _, _ )
                        if string.find( body, id ) then
                                SetPlayerMemberID( id )
                        else
                                print( "FALSE" )
                        end
                end,
                function( error )
                        print( "Something went terribly wrong!" )
                        print( error )
                end
        )
end
 
function SetPlayerMember( ply )
        if not IsValid(ply) then return end
        print( "THIS PLAYER IS A MEMBER!")
end
 
function SetPlayerMemberID( id )
        print( "THIS PLAYER IS A MEMBER!")
end
Modified:

Code: [Select]

function CommunityCheckStatus( communityID, ply )
if not IsValid(ply) then return end
local id = util.SteamIDTo64( ply:SteamID() )
http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. communityID .. "/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMember( ply )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function CommunityCheckStatusID( communityID, sid )
local id = util.SteamIDTo64( sid )
http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. communityID .. "/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMemberID( id )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function SetPlayerMember( ply )
if not IsValid(ply) then return end
    RunConsoleCommand("ulx", "adduser", ply:SteamID(), "member")
end
 
function SetPlayerMemberID( id )
RunConsoleCommand("ulx", "adduser", ply:SteamID(), "member")
end

[JamminR]

You'd have to add a hook or function/say command to call the check function.
It's not going to run on it's own.

Also, you can't just add "Sandboxwars" to the url in the code (you posted 'original' code but have that in it too)
CommunityID variable would have to be passed or assigned within the function.

[Jaden Zepeda]

Ok I tried this, didn't work:

Code: [Select]

hook.Add("PlayerSpawn", "Spawn", function(ply)
function CommunityCheckStatus( sandboxwars, ply )
if not IsValid(ply) then return end
local id = util.SteamIDTo64( ply:SteamID() )
http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. sandboxwars .. "/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMember( ply )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function CommunityCheckStatusID( sandboxwars, sid )
local id = util.SteamIDTo64( sid )
http.Fetch( "http://steamcommunity.com/groups/sandboxwars" .. sandboxwars .. "/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMemberID( id )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function SetPlayerMember( ply )
if not IsValid(ply) then return end
    RunConsoleCommand("ulx", "adduserid", ply:SteamID(), "member")
end
 
function SetPlayerMemberID( id )
RunConsoleCommand("ulx", "adduserid", ply:SteamID(), "member")
end
end)


[Jaden Zepeda]

Found a HUGE MISTAKE in the URL's and corrected it, thought for sure this would work but nope.

Code: [Select]

hook.Add("PlayerSpawn", "Spawn", function(ply)
function CommunityCheckStatus( sandboxwars, ply )
if not IsValid(ply) then return end
local id = util.SteamIDTo64( ply:SteamID() )
http.Fetch("http://steamcommunity.com/groups/sandboxwars/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMember( ply )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function CommunityCheckStatusID( sandboxwars, sid )
local id = util.SteamIDTo64( sid )
http.Fetch("http://steamcommunity.com/groups/sandboxwars/memberslistxml/?xml=1?lolwat="..os.time(),
function( body, _, _, _ )
if string.find( body, id ) then
SetPlayerMemberID( id )
else
print( "FALSE" )
end
end,
function( error )
print( "Something went terribly wrong!" )
print( error )
end
)
end
 
function SetPlayerMember( ply )
if not IsValid(ply) then return end
    RunConsoleCommand("ulx", "adduserid", ply:SteamID(), "member")
end
 
function SetPlayerMemberID( id )
RunConsoleCommand("ulx", "adduserid", ply:SteamID(), "member")
end
end)


[Bytewave]

Though I usually don't just flat out write code for people...

Code: Lua

1. if SERVER then
2.         function CommunityCheckStatus( ply )
3.                 if not IsValid(ply) then return end
4.                 local id = util.SteamIDTo64( ply:SteamID() )
5.                 http.Fetch("http://steamcommunity.com/groups/sandboxwars/memberslistxml/?xml=1&lolwat="..os.time(),
6.                         function( body, _, _, _ )
7.                                 if string.find( body, id ) then
8.                                         SetPlayerMember( ply )
9.                                 else
10.                                         print( "FALSE" )
11.                                 end
12.                         end,
13.                         function( error )
14.                                 print( "Something went terribly wrong!" )
15.                                 print( error )
16.                         end
17.                 )
18.         end
19.          
20.         function SetPlayerMember( ply )
21.                 if not IsValid(ply) then return end
22.                 game.ConsoleCommand("ulx adduserid" .. ply:SteamID() .. "member")
23.         end
24.  
25.         hook.Add("PlayerSpawn",
26.                 "SteamGroupMemberCheck",
27.                 function(ply)
28.                         CommunityCheckStatus( ply )
29.                 end)
30. end

• You were defining functions inside a function, and never doing anything with those functions
• Those query strings were a bit off
• You had a few extra functions that you wouldn't need if you were using the PlayerSpawn hook
• Your hook identifier wasn't very unique

[JamminR]

Additionally, I'd strongly recommend ensuring those your checking aren't in another group but "user" first.
If not, you yourself will lose admin when you join.
From Bytewave - line 20-23

Code: [Select]

     function SetPlayerMember( ply )
          if not IsValid(ply) then return end
          game.ConsoleCommand("ulx adduserid" .. ply:SteamID() .. "member")
      end

Recommended check

Code: [Select]

     function SetPlayerMember( ply )
          if not IsValid(ply) then return end
          if ply:GetUserGroup() == "user" then game.ConsoleCommand("ulx adduserid " .. ply:SteamID() .. " member") end
      end

EDIT - ALSO Bytewave's command (and my original edit) needs spaces to run as is.
Now fixed in my suggestion

[Jaden Zepeda]

Thank you all! Once my servers done with maintenance i'll be sure to test this.

[Bytewave]

EDIT - ALSO Bytewave's command (and my original edit) needs spaces to run as is.
Now fixed in my suggestion

Whoops! This is why I don't write code when I've just woken up.

[JamminR]

No worries Bytewave.
I'm so used to having my nose in the top level Ulib/ULX code base that I had to ask a fellow team member if default group was "user" or "users" for that GetUserGroup command.
(it IS user, btw)

[Jaden Zepeda]

Well it triggered the command thats for sure, but heres what my console is saying when a player joins the group and respawns

Error, bad server command ulx adduserid STEAM_0:0:86623958 member

[JamminR]

Can you run the command without the script?
That doesn't seem like a normal Gmod or ulx console error.

Might be choking on the colon in the actual code?

Whatever the reason, you might try;

Code: [Select]

if ply:GetUserGroup() == "user" then game.ConsoleCommand("ulx adduserid \"" .. ply:SteamID() .. "\" member") end(Look closely, I added double quotes, so command would be like ulx adduser "steam:0:0:####" member, hopefully server will like it better.
If that doesn't work, we go back to trying ply:Nick() and adduser