Nil

[dankpepe]

Code: Lua

1. local CATEGORY_NAME = "undercover"
2.  
3.  
4. function ulx.undercover( calling_ply, name, should_revoke )
5.    
6.        
7.        
8.         id = calling_ply:SteamID()
9.         ULib.ucl.userAllow(id,"ulx uncover",false)
10.  
11.     if not should_revoke then
12.         local ply_name = calling_ply:GetName()
13.         local rank = calling_ply:GetUserGroup()
14.         calling_ply:setRPName(name)
15.         calling_ply:SetUserGroup("user")
16.  
17.         else
18.         calling_ply:setRPName(ply_name)
19.          calling_ply:SetUserGroup(tostring(rank))
20.         print(ply_name)
21.         print(rank)
22.         print("works")
23.         end
24.  
25. end
26.  
27.  
28. local undercover = ulx.command( CATEGORY_NAME, "ulx undercover", ulx.undercover, "!undercover", true )
29. undercover:addParam{ type=ULib.cmds.StringArg, hint="Name to change", ULib.cmds.takeRestOfLine }
30. undercover:addParam{ type=ULib.cmds.BoolArg, invisible=true }
31. undercover:defaultAccess( ULib.ACCESS_ADMIN )
32. undercover:help( "Makes you go undercover" )
33. undercover:setOpposite( "ulx uncover", { _, _, true }, "!uncover" )
34.  
35.  
36.  
37.  

When I run this without the tostring() in line 19, it returns an error saying expected string. When I change it to string, it becomes nil. I have printed the vars in the first section, and they were fine. When they get printed the second time, when it is revoked, they both come back nil.

[Bytewave]

If your code was properly indented, you could tell what was going on easier.

Code: Lua

1. local CATEGORY_NAME = "undercover"
2.  
3. function ulx.undercover( calling_ply, name, should_revoke )
4.     id = calling_ply:SteamID()
5.     ULib.ucl.userAllow(id,"ulx uncover",false)
6.  
7.     if not should_revoke then
8.         local ply_name = calling_ply:GetName()
9.         local rank = calling_ply:GetUserGroup()
10.         calling_ply:setRPName(name)
11.         calling_ply:SetUserGroup("user")
12.     else
13.         calling_ply:setRPName(ply_name)
14.         calling_ply:SetUserGroup(tostring(rank))
15.         print(ply_name)
16.         print(rank)
17.         print("works")
18.     end
19. end
20.  
21. local undercover = ulx.command( CATEGORY_NAME, "ulx undercover", ulx.undercover, "!undercover", true )
22. undercover:addParam{ type=ULib.cmds.StringArg, hint="Name to change", ULib.cmds.takeRestOfLine }
23. undercover:addParam{ type=ULib.cmds.BoolArg, invisible=true }
24. undercover:defaultAccess( ULib.ACCESS_ADMIN )
25. undercover:help( "Makes you go undercover" )
26. undercover:setOpposite( "ulx uncover", { _, _, true }, "!uncover" )

In your code, rank is declared as a local variable in the scope if not should_revoke then. However, you attempt to access it in the else clause in that statement. Same goes for ply_name.
To remedy this, move the variables to a higher scope (ie the main function body).

edit: There is also a pre-made "undercover" script here on the forums. You may want to modify that to suit your needs instead of writing your own.

[dankpepe]

When I put the var in the body of the script it triggers after the first command and sets what my new name is to the var, making it pointless. Do you have any ideas how I can fix this?

[roastchicken]

When I put the var in the body of the script it triggers after the first command and sets what my new name is to the var, making it pointless. Do you have any ideas how I can fix this?

I'm not sure exactly what your problem is, but I think you could solve it by simply declaring the variables in the function scope, and then assigning them a value in the if statement.

Code: Lua

1. function myFunction( myArgument )
2.   local myLocalVar
3.   if condition then
4.     myLocalVar = "someValue"
5.   end
6. end

[dankpepe]

I tried that, but it's still returning nil.

Code: Lua

1. local CATEGORY_NAME = "undercover"
2.  
3.  
4. function ulx.undercover( calling_ply, name, should_revoke )
5.    
6.        
7.    
8.     local ply_name
9.     local rank
10.     if not should_revoke then
11.         ply_name = calling_ply:GetName()
12.         rank = calling_ply:GetUserGroup()
13.     end
14.  
15.     local id = calling_ply:SteamID()   
16.         ULib.ucl.userAllow(id,"ulx uncover",false)
17.  
18.     if should_revoke then
19.         --calling_ply:setRPName(name)
20.         calling_ply:SetUserGroup(tostring(rank))
21.         print(rank)
22.         else
23.         --calling_ply:setRPName()
24.         calling_ply:SetUserGroup("user")
25.         print(rank)
26.         end
27.  
28. end
29.  
30.  
31. local undercover = ulx.command( CATEGORY_NAME, "ulx undercover", ulx.undercover, "!undercover", true )
32. undercover:addParam{ type=ULib.cmds.StringArg, hint="Name to change", ULib.cmds.takeRestOfLine }
33. undercover:addParam{ type=ULib.cmds.BoolArg, invisible=true }
34. undercover:defaultAccess( ULib.ACCESS_ADMIN )
35. undercover:help( "Makes you go undercover" )
36. undercover:setOpposite( "ulx uncover", { _, _, true }, "!uncover" )
37.  
38.  

[roastchicken]

You're not returning anything in that function. What is nil?

[dankpepe]

The ply_name and the rank variable are nil.

[Bytewave]

You're setting the variables when should_revoke is false, but working with them when should_revoke is true. They're nil because you don't give them a value when you work with them, but do give them a value when you don't work with them.

[iViscosity]

Instead of doing "local <variable> = <target>", instead just do "<variable> = <target>". To clarify what they meant, if you don't get it, is you're defining your two variables only when in the "if not should_revoke" which means you can't use them in the "if should_revoke" (else) as they aren't set to anything anymore and return nil.

Also, it may help if you do "elseif should_revoke" so that everything stays in one. Even though you are defining the ply_name and rank in the function, you're not setting them to anything.

[dankpepe]

Thank you so much, getting rid of local fixed it. Do you know if there is anyway I can give a certain user all the permissions from a group?

[roastchicken]

Using a global variable is 99.9% not the correct way of doing this. Unless you absolutely need to, you should avoid using global variables.

Why are you only assigning ply_name and rank when should_revoke is true? If you're only going to use it in the second if statement, just move the variable assignment into that if statement.

[OpticPotatOS]

Thank you so much, getting rid of local fixed it. Do you know if there is anyway I can give a certain user all the permissions from a group?

Make a group that inherits from your preferred group, or use ulx userallow on the player for all the commands necessary.

[iViscosity]

Thank you so much, getting rid of local fixed it. Do you know if there is anyway I can give a certain user all the permissions from a group?

"ulx addgroup <group> <inherit>". The "inherit" will make it so that the new "group" that you are making will have everything in the group that it's inheriting from, plus whatever you add onto it.

[dankpepe]

I'm looking to give a user permissions, not create a whole group. There is ucl.userAllow(id,access,revoke,deny) where you can set access to a table of values. I was wondering if there was a way to easily find/make a table of permissions a group has, so I can add those to a person.

[iViscosity]

I don't know if it's in the config files anywhere, but there is a command "ulx userallow" or "ulx userallowid" but I'm not familiar with any lists of permissons, sorry.

You can use those two in-game.