Sourcebans & ULX/ULib

[JamminR]

TrulyRazor, my apologies, I've never used either of these projects, but my guess would be - do you have a functioning sourcebans database that this can connect to, with admins in it?
From my understanding, this won't create new database/admins, it only adds bans to an already existing.
Someone more experienced can hopefully help.

Storm,
It's my understanding sourcebans won't run on Gmod, this only connects to a database created by sourcebans.
I'd experienced guestimate that the local Gmod bans file would still remain, as long as you didn't use the (2nd/replace) method from the first post.

[TrulyRazor]

TrulyRazor, my apologies, I've never used either of these projects, but my guess would be - do you have a functioning sourcebans database that this can connect to, with admins in it?
From my understanding, this won't create new database/admins, it only adds bans to an already existing.
Someone more experienced can hopefully help.

Storm,
It's my understanding sourcebans won't run on Gmod, this only connects to a database created by sourcebans.
I'd experienced guestimate that the local Gmod bans file would still remain, as long as you didn't use the (2nd/replace) method from the first post.

I fixed the issue!

For anyone encountering the Lua Error: [ERROR] addons/ulx/lua/includes/modules/sourcebans.lua:247: attempt to index field 'Select Admin Groups' (a nil value) error,
the thread is misleading. You actually need to replace the code he specified for line 178, not 177. AKA right below this line:

    ["Select Admin Groups"] = "SELECT flags, immunity, name FROM %s_srvgroups";

So for instance, your code should look like this after you replace line 178:

local queries = {
    -- BanChkr
    ["Check for Bans"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL AND (authid = '%s' OR ip = '%s') LIMIT 1";
    ["Check for Bans by IP"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL AND ip = '%s' LIMIT 1";
    ["Check for Bans by SteamID"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL AND authid = '%s' LIMIT 1";
    ["Get All Active Bans"] = "SELECT ip, authid, name, created, ends, length, reason, aid  FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL;";
   
    ["Log Join Attempt"] = "INSERT INTO %s_banlog (sid, time, name, bid) VALUES( %i, %i, '%s', %i)";
   
    -- Admins
    ["Select Admin Groups"] = "SELECT flags, immunity, name FROM %s_srvgroups";
--    ["Select Admins"] = "SELECT a.aid, a.user, a.authid, a.srv_group, a.srv_flags, a.immunity FROM %s_admins a, %s_admins_servers_groups g WHERE g.server_id = %i AND g.admin_id = a.aid";
["Select Admins"] = "SELECT a.aid, a.user, a.authid, a.srv_group, a.srv_flags, a.immunity FROM %s_admins a";
   
    -- Bannin
    ["Ban Player"] = "INSERT INTO %s_bans (ip, authid, name, created, ends, length, reason, aid, adminIp, sid, country) VALUES('%s', '%s', '%s', %i, %i, %i, '%s', %i, '%s', %i, ' ')";
    -- Unbannin
    ["Unban SteamID"] = "UPDATE %s_bans SET RemovedBy = %i, RemoveType = 'U', RemovedOn = UNIX_TIMESTAMP(), ureason = '%s' WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL AND authid = '%s'";
    ["Unban IPAddress"] = "UPDATE %s_bans SET RemovedBy = %i, RemoveType = 'U', RemovedOn = UNIX_TIMESTAMP(), ureason = '%s' WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND removetype IS NULL AND ip = '%s'";
};

Thanks for the help, JamminR!

[rainbow Dash]

Storm,
It's my understanding sourcebans won't run on Gmod, this only connects to a database created by sourcebans.
I'd experienced guestimate that the local Gmod bans file would still remain, as long as you didn't use the (2nd/replace) method from the first post.

You are kind of right and wrong here.

Existing bans will still remain, as ULX will still pertain to its bans. When a new ban takes place, ULX does not ban the player (unless the database wont connect) but rather remembers they were banned, and tells the database to add it to the ban list, and then bans them through the banid method.

Web based bans, on the other hand, do not log into ulx at all from what I have seen, they appear to just get added to the ban list on all servers.

[rainbow Dash]

There is a serious issue with this addon.

When the addon fails to connect to the database, all bans are forgotten. Players who have been banned can rejoin.

A suggestion to resolve this: Every time the database synchronizes, it saves a local copy of all bans, from which it reads its bans from. Every 30 minutes, it drops its MySQL connection to sourcebans and retries it from scratch to synchronize this database. This way, if the database cannot be retrieved, we still have bans that take effect.

[V-Rico]

So, guys. If you got problems with incorrect symbols in base (like СЛОВО), just add:

Code: [Select]

local query_names = self:query("SET NAMES utf8");
query_names:start();after

Code: [Select]

function databaseOnConnected(self)

[V-Rico]

And what's about removeing admins from group when admin removes them from sourcebans?

[rainbow Dash]

I take it ya ment line 270 as it is the line that says

Code: [Select]

local adminID, adminIP = getAdminDetails(admin);
I changed that to

Code: [Select]

local adminID, adminIP = getAdminDetails(admin) or "";
And done a voteban against myself, I was banned from the server (Lan one), however it still gave the error.
The server did not crash, however as I said it was just a lan based one so it was only me on it, so the lack of 23 other players might have had something to do with that.
It also did not write the ban to sourcebans (it writes them fine using !ban)

This issue is still occuring, but wouldn't it make more sense to be...

Code: [Select]

local adminID, adminIP = getAdminDetails(admin) or "", "";
... I mean, its setting two variables here, not 1, so getAdminDetails(admin) must be returning two values, meaning if you added

Code: [Select]

or ""; you'd be just setting adminID to "" and leaving adminIP undefined.

[PAL-18]

I finally got this module working.  After trying some stuff with mysqloo i figured out why it wasnt working for me and this should help others:

Mysqloo asks you to install a lib file (libmysql.dll or libmysql.lib) that you stick in same directory as srcds executable.  My MySQL server version was newer which is why it wasnt working.  You need to install the lib file from the same version of the MySQL server you're using.  Once you figure out the version number, you can download it at http://downloads.mysql.com/archives/community/  The file will be located in the lib folder of the archive.

[BlueGhostHD]

Is there a way to add the player/user to a specific group on Sourcebans automatically when a player's group is changed in ULX?

[PAL-18]

Can this plugin populate the ban tab with bans from sourcebans?

[benjanmin112]

Can someone help me do this like make a video or something I am really bad at coding and recoding even tho I got the codes or can someone just send sourcebans to me where it is already done thanks

[Majora]

Can someone help me do this like make a video or something I am really bad at coding and recoding even tho I got the codes or can someone just send sourcebans to me where it is already done thanks

https://www.youtube.com/watch?v=_b1mHn9OQ0A

It's actually a really handy tutorial someone posted in this thread (Way earlier, I believe). It's what I used to install Sourcebans on my Gmod server, and it works just fine.

[dataviruset]

If anybody's interested, I made some modifications to the SQL queries on our server because it seems the script doesn't always care about if the ban has expired. Also I added support for STEAM_1:xxxxx like Steam-ID's. These queries are the same kind that the SourceBans SourceMod plugin runs.

Code: Lua

1. local queries = {
2.     -- BanChkr
3.         -- Added support for STEAM_1:x:xxxxxx like Steam-IDs by substring Steam-ID on index 8. /dataviruset
4.     ["Check for Bans"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE ((type = 0 AND authid REGEXP '^STEAM_[0-9]:%s$') OR (type = 1 AND ip = '%s')) AND (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL LIMIT 1";
5.         -- OLD: SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND (authid = '%s' OR ip = '%s') LIMIT 1
6.         ["Check for Bans by IP"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND ip = '%s' LIMIT 1";
7.         -- Added support for STEAM_1:x:xxxxxx like Steam-IDs by substring Steam-ID on index 8. /dataviruset
8.     ["Check for Bans by SteamID"] = "SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND authid REGEXP '^STEAM_[0-9]:%s$' LIMIT 1";
9.         -- OLD: SELECT bid, name, ends, authid, ip FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND authid = '%s' LIMIT 1
10.     ["Get All Active Bans"] = "SELECT ip, authid, name, created, ends, length, reason, aid  FROM %s_bans WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL;";
11.    
12.     ["Log Join Attempt"] = "INSERT INTO %s_banlog (sid, time, name, bid) VALUES( %i, %i, '%s', %i)";
13.    
14.     -- Admins
15.     ["Select Admin Groups"] = "SELECT flags, immunity, name FROM %s_srvgroups";
16.     ["Select Admins"] = "SELECT a.aid, a.user, a.authid, a.srv_group, a.srv_flags, a.immunity FROM %s_admins a, %s_admins_servers_groups g WHERE g.server_id = %i AND g.admin_id = a.aid";
17.    
18.     -- Bannin
19.     ["Ban Player"] = "INSERT INTO %s_bans (ip, authid, name, created, ends, length, reason, aid, adminIp, sid, country) VALUES('%s', '%s', '%s', %i, %i, %i, '%s', %i, '%s', %i, ' ')";
20.     -- Unbannin
21.     ["Unban SteamID"] = "UPDATE %s_bans SET RemovedBy = %i, RemoveType = 'U', RemovedOn = UNIX_TIMESTAMP(), ureason = '%s' WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND authid = '%s'";
22.     ["Unban IPAddress"] = "UPDATE %s_bans SET RemovedBy = %i, RemoveType = 'U', RemovedOn = UNIX_TIMESTAMP(), ureason = '%s' WHERE (length = 0 OR ends > UNIX_TIMESTAMP()) AND RemoveType IS NULL AND ip = '%s'";
23. };

Code: Lua

1. function checkBan(ply, steamID, ip, name)
2.     -- Added support for STEAM_1:x:xxxxxx like Steam-IDs by substring Steam-ID on index 8. /dataviruset
3.     local queryText = queries["Check for Bans"]:format(config.dbprefix, string.sub(steamID, 9), ip);
4.     local query = database:query(queryText);
5.         -- print(queryText);
6.     if (query) then
7.         query.steamID   = steamID;
8.         query.player    = ply;
9.         query.name      = name;
10.         query.onData    = banCheckerOnData;
11.         query.onFailure = banCheckerOnFailure;
12.         query:start();
13.     else
14.         table.insert(database.pending, {queryText, steamID, name, ply});
15.         CheckStatus();
16.     end
17. end
18.  
19. function checkBanBySteamID(steamID, callback)
20.     -- Added support for STEAM_1:x:xxxxxx like Steam-IDs by substring Steam-ID on index 8. /dataviruset
21.     local query = database:query(queries["Check for Bans by SteamID"]:format(config.dbprefix, string.sub(steamID, 9)));
22.         query.steamID   = steamID;
23.         query.callback  = callback;
24.         query.onSuccess = checkSIDOnSuccess;
25.         query.onFailure = checkSIDOnFailure;
26.         query:start();
27. end

[gamemann]

Hello everybody, I have one problem with this script. Basically, every time my web server goes down, it will crash all my servers. It has to due with it losing connection to the database. Now, most of you will say "Well don't let the Web Server go down", well it shouldn't be crashing the servers even if the web server goes down. I am trying to fix my web server but is there anyway to make it so the script won't make the servers go down if it loses connection to the database?

I am not that good with lua so I wouldn't be able to do that

Thanks,
Gamemann

[Bytewave]

I had a quick question:
Is there any way to make it actually report the banning admin's name to Sourcebans?
If so... code?