Lua Halo Glow Help

[ChaosWolf]

So what im wanting is to make a code so that the client will highlight the target he/she is currently marking, say I am trying to select a small object surrounded by many other objects, it is to help with accuracy in selecting items. here's what I have so far.

Code: Lua

1. hook.Add( "PreDrawHalos", "AddHalos", function()
2.         halo.Add( ents.FindByClass( "prop_physics*" ), Color( 255, 0, 0 ), 5, 5, 2 )
3. end )

but this makes all props glow, I just need something to say if ply:TEAM_PROP then do
but im not sure how to get it to work properly and in such a way that only targeted props are highlighted.

I'm still new to lua and am learning as I go. so I could use the help. anyone care to help me revise it?

EDIT:

OK here is the completed script for anyone who stumbled across this halo glow prop thingy.

[Neku]

Get the player's UniqueID and find props with that.
Props spawned by the player will have their UniqueID.

[ChaosWolf]

You misunderstood what I'm asking. As in prop hunt when finding a prop to change into, the prop you are currently targeting should glow. As in all players on team prop. Not just 1 person. It works fine.. I just need to restrict the halo to target only.

[Neku]

By targeting, do you mean looking at the prop before becoming it?

[ChaosWolf]

Yes exactly.

When looking at it, it should glow is its a valid prop to assist selection accuracy before becoming the prop.

[Neku]

Code: Lua

1. function GetTraceProp() -- This is a clientside function, please do not run it serverside.
2.         local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )
3.         for k,v in pairs( ents.FindByClass( "prop_physics" ) ) do
4.                 if v == trace.Entity then
5.                         return v
6.                 end
7.         end
8. end

Here's a function to get the prop the player is looking at.

Replace ents.FindByClass( "prop_physics*" ) with GetTraceProp()

[ChaosWolf]

OH... OKAY I see what you did.... yea that makes perfect sense now, I appreciate it.

so I just combine the two in a single string or a separate function and continue to call the halo as a hook, while calling the GetProp as the primary function?

[Neku]

halo.Add()'s first parameter takes either an entity or a table of entities.
ents.FindByClass() returns a table of prop_physics entities.
GetTraceProp() returns a single entity, which is the one the player is looking at.

You'd need to add the code I posted into the same lua file as the one using halo.Add().

Then you would do:

Code: Lua

1. hook.Add( "PreDrawHalos", "AddHalos", function()
2.         halo.Add( GetTraceProp(), Color( 255, 0, 0 ), 5, 5, 2 )
3. end )

[ChaosWolf]

[ERROR] stack overflow
  1. __mul - [C]:-1
   2. GetPlayerTrace - lua/includes/extensions/util.lua:43
    3. GetTraceProp - lua/autorun/sh_halo.lua:8
     4. GetTraceProp - lua/autorun/sh_halo.lua:9
      5. GetTraceProp - lua/autorun/sh_halo.lua:9
       6. GetTraceProp - lua/autorun/sh_halo.lua:9
        7. GetTraceProp - lua/autorun/sh_halo.lua:9
         8. GetTraceProp - lua/autorun/sh_halo.lua:9
          9. GetTraceProp - lua/autorun/sh_halo.lua:9
           10. GetTraceProp - lua/autorun/sh_halo.lua:9
            11. GetTraceProp - lua/autorun/sh_halo.lua:9
             12. GetTraceProp - lua/autorun/sh_halo.lua:9
              13. GetTraceProp - lua/autorun/sh_halo.lua:9
               14. GetTraceProp - lua/autorun/sh_halo.lua:9
                15. GetTraceProp - lua/autorun/sh_halo.lua:9
                 16. GetTraceProp - lua/autorun/sh_halo.lua:9


That Doesn't look healthy

it also mega-spams TEST [Addon Example Directory>Directory>blah>blah>blah]
which also runs through all my pointshop inventory as well.
Sever Meltdown = Immenent.

[Neku]

Hm, it seems to be running much harder than it should be.

Try getting a trace, then adding the halo, instead of using a halo that is constantly looking for a prop.

[ChaosWolf]

this have it set up now, I don't see what the problem is, it all looks fine.

Code: Lua

1. function GetTraceProp() -- This is a clientside function, please do not run it serverside.
2.         local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )
3.         for k,v in pairs( GetTraceProp() ) do
4.                 if v == trace.Entity then
5.                         return v
6.                 end
7.         end
8. end
9. -- What Kind Of Glow?
10. hook.Add( "PreDrawHalos", "AddHalos", function()
11.         halo.Add( GetTraceProp(), Color( 140, 0, 255 ), 5, 5, 2 )
12. end )
13.  

are you asking me to flip the two?

[Neku]

The issue is my part of the code, it's running too many times.

[ChaosWolf]

I think I've got it...  my partner and I took a second look at it. this is what we came up with


you had

Code: Lua

1. local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )

we have

Code: Lua

1. local trace = util.TraceLine( util.GetPlayerTrace( ply, dir ) )

see the difference? im running it now I will let you know my results.

[Decicus]

this have it set up now, I don't see what the problem is, it all looks fine.

Code: Lua

1. function GetTraceProp() -- This is a clientside function, please do not run it serverside.
2.         local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )
3.         for k,v in pairs( GetTraceProp() ) do
4.                 if v == trace.Entity then
5.                         return v
6.                 end
7.         end
8. end
9. -- What Kind Of Glow?
10. hook.Add( "PreDrawHalos", "AddHalos", function()
11.         halo.Add( GetTraceProp(), Color( 140, 0, 255 ), 5, 5, 2 )
12. end )
13.  

are you asking me to flip the two?

You weren't supposed to replace "ents.FindByClass( "prop_physics" )" in Neku's code with GetTraceProp(), you were supposed to replace it in your halo.Add code. Right now, the function is trying to loop through itself in the for loop, causing the stack overflow.

I think I've got it...  my partner and I took a second look at it. this is what we came up with


you had

Code: Lua

1. local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )

we have

Code: Lua

1. local trace = util.TraceLine( util.GetPlayerTrace( ply, dir ) )

see the difference? im running it now I will let you know my results.

This wouldn't even work due to "ply" not being specified, which is what "LocalPlayer()" is supposed to be.

The problem here wasn't Neku's original code, it was just a misunderstanding on your part (it can happen to everyone, I'm not trying to say anything bad about you).

Replace line 3 in this code (taken from one of Wolf's replies):

Code: Lua

1. function GetTraceProp() -- This is a clientside function, please do not run it serverside.
2.         local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )
3.         for k,v in pairs( GetTraceProp() ) do
4.                 if v == trace.Entity then
5.                         return v
6.                 end
7.         end
8. end
9. -- What Kind Of Glow?
10. hook.Add( "PreDrawHalos", "AddHalos", function()
11.         halo.Add( GetTraceProp(), Color( 140, 0, 255 ), 5, 5, 2 )
12. end )

With this:

Code: Lua

1. for k,v in pairs( ents.FindByClass( "prop_physics" ) ) do

So the finished code looks like this:

Code: Lua

1. function GetTraceProp() -- This is a clientside function, please do not run it serverside.
2.         local trace = util.TraceLine( util.GetPlayerTrace( LocalPlayer() ) )
3.         for k,v in pairs( ents.FindByClass( "prop_physics" ) ) do
4.                 if v == trace.Entity then
5.                         return v
6.                 end
7.         end
8. end
9. -- What Kind Of Glow?
10. hook.Add( "PreDrawHalos", "AddHalos", function()
11.         halo.Add( GetTraceProp(), Color( 140, 0, 255 ), 5, 5, 2 )
12. end )

Which is what Neku originally meant by

Replace ents.FindByClass( "prop_physics*" ) with GetTraceProp()

[ChaosWolf]

alright thanks for the input, I appreciate it. I will remember that next time, it looks like I was trying to call trace props too soon. I will try this.