Did I do something wrong?

[Tomzen]

Hi, did a quick stab at this:

Code: Lua

1. function ulx.search( calling_ply, engine, search )
2.     if engine == "twitch" or engine == "Twitch" then
3.         link = "\"http://www.twitch.tv/search?query="
4.                 engine = "Twitch"
5.     end
6.    
7.     if engine == "youtube" or engine == "Youtube" then
8.         link = "\"http://www.youtube.com/results?search_query="
9.                 engine = "Youtube"
10.     end
11.    
12.     if engine == "google" or engine == "Google" then
13.         link = "\"http://www.google.com.au/#q="
14.                 engine = "Google"
15.     end
16.    
17.     if engine == "bing" or engine == "Bing" then
18.         link = "\"http://www.bing.com/search?q="
19.                 engine = "Bing"
20.     end
21.    
22.     if engine == "yahoo" or engine == "Yahoo" then
23.         link = "\"http://search.yahoo.com/search?p="
24.                 engine = "Yahoo"
25.     end
26.    
27.     if link == undefined or link == null then
28.         ULib.tsayError( calling_ply, "An error occurred, please try again.", true )
29.         return
30.     else
31.                 search = search .. "\""
32.         ULib.tsayError( calling_ply, "You searched for \"" .. search .. " on " .. engine, true )
33.         calling_ply:SendLua("gui.OpenURL(".. link .. search ..")")
34.     end
35.    
36. end
37. local search = ulx.command( "Tom's Fun", "ulx search", ulx.search, "!search", true )
38. search:addParam{ type=ULib.cmds.StringArg, hint="Engine: (Twitch, Youtube, Google, Bing, Yahoo." }
39. search:addParam{ type=ULib.cmds.StringArg, hint="Search" }

It works fine but for some reason it remembers what link was used previously (not the "search" part) It also isn't appearing in a category on the menu.

Example:
If I type "ulx search google Pie" in console, it will work fine.
then If I type "ulx search asdfasdf poop" in console, it will search google for "poop" (and its not because of line 14)

And as far as I see it should be showing in "Tom's Fun" category, but nope.

[XxLMM13xX]

Why not add a check to make sure the users using his a engin the command knows!

If engine == "" then
    ULib.tsayError( caling_ply, "This is not the right engine!")
    Return
End

I'm writing this on my phone so I hope it makes sense and helps you!

[Tomzen]

Why not add a check to make sure the users using his a engin the command knows!

If engine == "" then
    ULib.tsayError( caling_ply, "This is not the right engine!")
    Return
End

I'm writing this on my phone so I hope it makes sense and helps you!

Yeah I thought so too, but it didn't work, and it wouldn't run the command to start off with if "engine" was blank.
*cough* *calling *cough*

[Timmy]

Undefined lua variables are nil. Not undefined or null. Lua will see your "undefined" and "null" as variables. Your test passes because they are both nil. But what if they weren't? It's better to just compare with nil.

You haven't specified who's allowed to access the command. You'll have to tell the defaultAccess function.

The reason it is sorta remembering the previous engine is because you've defined "link" as a global variable. It will remember the old value and reuse it. Make it local so it only exists within your function.

Edit: elaborated

[Caustic Soda-Senpai]

you've defined "link" as a global variable. It will remember the old value and reuse it. Make it local so it only exists within your function.

As well, if your category name isn't working, add the line

Code: Lua

1. local CATEGORY_NAME = "Tom's Fun"

and replace

Code: Lua

1. local search = ulx.command( "Tom's Fun", "ulx search", ulx.search, "!search", true )

with

Code: Lua

1. local search = ulx.command( CATEGORY_NAME, "ulx search", ulx.search, "!search", true )

As well, as Timmy ALSO said, you failed to add who can access the command. Add the line:

Code: Lua

1. search:defaultAccess( ULib.ACCESS_USER )

along with your other permissions.


Also, is there a reason as to why you have all of these as individual if statements? Why not if and elseif?

[Tomzen]

As well, if your category name isn't working, add the line

Code: Lua

1. local CATEGORY_NAME = "Tom's Fun"

and replace

Code: Lua

1. local search = ulx.command( "Tom's Fun", "ulx search", ulx.search, "!search", true )

with

Code: Lua

1. local search = ulx.command( CATEGORY_NAME, "ulx search", ulx.search, "!search", true )

As well, as Timmy ALSO said, you failed to add who can access the command. Add the line:

Code: Lua

1. search:defaultAccess( ULib.ACCESS_USER )

along with your other permissions.


Also, is there a reason as to why you have all of these as individual if statements? Why not if and elseif?

Alright, I changed all that and It works (haven't tested the search part, gotta go out now) but If I use

Code: Lua

1. search:defaultAccess( ULib.ACCESS_USER )

I get "bad argument #1 to ULib.cmds.TranslateCommand:defaultAccess (string expected)"

So right now I'm using:

Code: Lua

1. search:defaultAccess( ULib.ACCESS_ALL )

Which allows it in the menu but USER dosent have access by default

In Full this is what I currently have:

Code: Lua

1. local CATEGORY_NAME = "Tom's Commands"
2. function ulx.search( calling_ply, engine, search )
3.  
4. if engine == "" then
5.         return
6. end
7.  
8.     if engine == "twitch" or engine == "Twitch" then
9.         link = "\"http://www.twitch.tv/search?query="
10.                 engine = "Twitch"
11.     end
12.  
13.     if engine == "youtube" or engine == "Youtube" then
14.         link = "\"http://www.youtube.com/results?search_query="
15.                 engine = "Youtube"
16.     end
17.  
18.     if engine == "google" or engine == "Google" then
19.         link = "\"http://www.google.com.au/#q="
20.                 engine = "Google"
21.     end
22.  
23.     if engine == "bing" or engine == "Bing" then
24.         link = "\"http://www.bing.com/search?q="
25.                 engine = "Bing"
26.     end
27.  
28.     if engine == "yahoo" or engine == "Yahoo" then
29.         link = "\"http://search.yahoo.com/search?p="
30.                 engine = "Yahoo"
31.     end
32.  
33.     if link == nil or link == "" then
34.         ULib.tsayError( calling_ply, "An error occurred, please try again.", true )
35.         return
36.     else
37.                 search = search .. "\""
38.         ULib.tsayError( calling_ply, "You searched for \"" .. search .. " on " .. engine, true )
39.         calling_ply:SendLua("gui.OpenURL(".. link .. search ..")")
40.     end
41.  
42. end
43. local search = ulx.command( CATEGORY_NAME, "ulx search", ulx.search, "!search", true )
44. search:addParam{ type=ULib.cmds.StringArg, hint="Engine: (Twitch, Youtube, Google, Bing, Yahoo." }
45. search:addParam{ type=ULib.cmds.StringArg, hint="Search" }
46. search:defaultAccess( ULib.ACCESS_ALL )

Also the reason I was using "undefined" and "null" was out of habit, I used to do a lot of javascript and this nature of code normally requires that.

[Aaron113]

"link" is still a global variable so it will still remember your links.  Add a local declaration in there.  (local link = false)

[Tomzen]

Ahh, thanks, I'll apply it when I get home.
And how about the other problem?

[Caustic Soda-Senpai]

I flamingoed-up when i did the ULib.ACCESS_USER, it should indeed have been: ULib.ACCESS_ALL. If user doesn't have permission by default, just give it to them in the XGUI permissions.

[joalars]

--totally unrelated test post--